Skip to content

Prevent duplicate display names#82

Merged
PVince81 merged 1 commit into
masterfrom
prevent-duplicate-displaynames
Aug 10, 2017
Merged

Prevent duplicate display names#82
PVince81 merged 1 commit into
masterfrom
prevent-duplicate-displaynames

Conversation

@PVince81

@PVince81 PVince81 commented Aug 4, 2017

Copy link
Copy Markdown
Contributor

Prevents duplicate display names

Fixes #77

@PVince81 PVince81 added this to the development milestone Aug 4, 2017
@PVince81 PVince81 self-assigned this Aug 4, 2017
@sharidas

sharidas commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

Shared my observation:

  • So once a group is created it does prevent creation of new group with same displayname.
    cg_dup_message

  • Another thing I have noticed ( pardon me if its a wrong test I did ), Lets say if we create two customgroupstest one and test two. Now rename test two to test one. It does allow:
    cg_dup

@PVince81

PVince81 commented Aug 8, 2017

Copy link
Copy Markdown
Contributor Author

@sharidas if you refresh the page you should see that the rename actually failed.

You need to check out this branch from core owncloud/core#28589 so that the PROPPATCH error detection works correctly.

@sharidas

sharidas commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

Aah I was thinking what am I doing wrong. Yes, refresh the page and no duplicates. 👍

@PVince81 PVince81 merged commit 743b0a7 into master Aug 10, 2017
@PVince81 PVince81 deleted the prevent-duplicate-displaynames branch August 10, 2017 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants